Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py-meson: Default FrameworkPath not found when using -std=C++<ver> or std=gnu++<ver> #26300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

py-meson: Default FrameworkPath not found when using -std=C++<ver> or std=gnu++<ver> #26300

wants to merge 1 commit into from
+12 −5

Conversation

christophecvr
Copy link
Contributor

Description

Closes: https://trac.macports.org/ticket/71165

Modifies the patch-meson-gcc-appleframeworks.diff patch file.
Bumps py-meson Portfile to revision 1

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.15
Xcode 11.5 / Command Line Tools 11.5

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@christophecvr
py-meson: Default FrameworkPath not found when using -std=C++<ver> or…
dad5a31 
… std=gnu++<ver>

  Closes: https://trac.macports.org/ticket/71165

  Modifies the patch-meson-gcc-appleframeworks.diff patch file.
  Bumps py-meson Portfile to revision 1
@macportsbot
Copy link

Notifying maintainers:
@reneeotten for port py-meson.
@SoapZA for port py-meson.

@macportsbot macportsbot added type: bugfix maintainer: open Affects an openmaintainer port labels Oct 25, 2024
@christophecvr
Copy link
Contributor Author

Some extra remarks who have nothing to do with this patch self:
From test results it looks that one procedure in the portfile does nothing except causing a list off warnings.
This is one of the reinplace's in line 142-156 I think: \

    pre-test {
        reinplace "s|/usr/bin/env python3$|${python.bin}|" \
            ${worksrcpath}/run_tests.py \
            ${worksrcpath}/run_cross_test.py \
            ${worksrcpath}/run_meson_command_tests.py \
            ${worksrcpath}/run_project_tests.py \
            ${worksrcpath}/run_unittests.py

        set testpath "${worksrcpath}/test\\ cases"
        fs-traverse f ${testpath} {
            if { [string match *.py ${f}] } {
                reinplace "s|/usr/bin/env python3$|${python.bin}|" ${f}
            }
        }
    }

But I self do not understand what this pre-test does.

@kencu
Copy link
Contributor

kencu commented Oct 25, 2024

But I self do not understand what this pre-test does.

It makes the testing scripts use a specific python instead of a generic python3 found on the PATH.

This is good for reproducibility, and for systems < 10.15 where no python3 exists in the PATH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reneeotten reneeotten

Labels
maintainer: open Affects an openmaintainer port type: bugfix
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christophecvr @macportsbot @kencu @reneeotten